Fix for events unit tests failing in CI #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears there are still few tests failing on events_test due to same issue. I'm looking more into that. |
|
https://travis-ci.org/armPelionEdge/maestro/builds/547370122 passed in the first run. This needs a rebase since another PR came in, fixing newline inconsistencies. |
SenRamakri
force-pushed
the
sen_UnitTestFixes_2
branch
from
0e2ab88
to
3ca9a11
Compare
SenRamakri
force-pushed
the
sen_UnitTestFixes_2
branch
from
3ca9a11
to
3ebc7fa
Compare
|
Pushed new commits rebased to master, also squashed few commits.. |
cmonr
approved these changes
Jun 18, 2019
johnmichaelwelsh
pushed a commit
that referenced
this pull request
Mar 5, 2020
Fix for events unit tests failing in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing events unit tests failing in CI and on debugging we found that to be test implementation issue as tests use too many parallel tests when not supported by the runtime. The current set of changes minimizes the required procs to be able to run CI.