Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .net example to support .Net5 #4

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

NeutraleNull
Copy link

This PR will update the example to support the newest .Net5 version.
It also adds extension callbacks.

@NeutraleNull
Copy link
Author

Still WIP. This should be moved to a folder just called net because .Net5 bundels the .net core and .net framework branches.
Also i still need to update the readme.

@X39
Copy link
Collaborator

X39 commented Jul 23, 2021

Feel free to continue working on the PR

@dedmen dedmen changed the title Update .net example to support .Net5 WIP: Update .net example to support .Net5 Aug 18, 2021
@dedmen
Copy link
Member

dedmen commented Aug 18, 2021

Hm is that not how you mark a PR as Draft? :D

@X39 X39 marked this pull request as draft August 18, 2021 16:52
@X39 X39 changed the title WIP: Update .net example to support .Net5 Update .net example to support .Net5 Aug 18, 2021
@X39
Copy link
Collaborator

X39 commented Aug 18, 2021

@dedmen there is a button apparently below "Reviewers" that allows to convert
https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request

Used it to convert this PR to a draft 😉

@X39 X39 added changes required Pull request requires changes prior to merging stale This issue or pull request was not updated in a long time and is potentially dead labels Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required Pull request requires changes prior to merging stale This issue or pull request was not updated in a long time and is potentially dead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants