fix: mutating hook for binoculars panicking on nil pointer dereference (

#294) * fix mutating hook for binoculars panicking on nil pointer dereference * lint fixes for binoculars webhook
armadaproject · Dec 4, 2023 · bda0e29 · bda0e29
1 parent cd140a6
commit bda0e29
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/api/install/v1alpha1/binoculars_webhook.go b/api/install/v1alpha1/binoculars_webhook.go
@@ -68,7 +68,10 @@ func (r *Binoculars) Default() {
 	}
 
 	// prometheus
-	if r.Spec.Prometheus.ScrapeInterval == nil {
-		r.Spec.Prometheus.ScrapeInterval = &metav1.Duration{Duration: time.Second * 10}
+	if r.Spec.Prometheus != nil && r.Spec.Prometheus.Enabled {
+		if r.Spec.Prometheus.ScrapeInterval == nil {
+			r.Spec.Prometheus.ScrapeInterval = &metav1.Duration{Duration: time.Second * 10}
+		}
 	}
+
 }