Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: WIP - Remove Lookout V1 from armada-operator #293

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

richscott
Copy link
Member

Lookout V1 has been removed from Armada, the project has fully migrated to the V2 version - remove the V1 support from the armada-operator tooling.

Also, correct some outdated goreleaser usage options, update many image versions with recent Armada images from Docker Hub.

@richscott richscott self-assigned this Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a596f28) 84.19% compared to head (7a2e6da) 84.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   84.19%   84.19%           
=======================================
  Files          15       15           
  Lines        3441     3441           
=======================================
  Hits         2897     2897           
  Misses        381      381           
  Partials      163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Also, correct some outdated goreleaser usage options, update
many image versions with recent Armada images from Docker Hub.

Signed-off-by: Rich Scott <richscott@sent.com>
@richscott richscott changed the title Remove Lookout V1 from armada-operator feat: Remove Lookout V1 from armada-operator Nov 6, 2023
@richscott richscott changed the title feat: Remove Lookout V1 from armada-operator feat: WIP - Remove Lookout V1 from armada-operator Nov 6, 2023
Copy link
Member

@dave-gantenbein dave-gantenbein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to see a way to extract the 0.3.103 tag repetition into a single value, but doesn't seem like a reason to block this PR.

@richscott richscott merged commit cd140a6 into main Nov 13, 2023
17 of 18 checks passed
@richscott richscott deleted the rich/remove-lookout-v1 branch November 13, 2023 20:21
Copy link
Contributor

@suprjinx suprjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richscott
Copy link
Member Author

I'd love to see a way to extract the 0.3.103 tag repetition into a single value, but doesn't seem like a reason to block this PR.

I tried specifying tag: $(ARMADA_RELEASE_VERSION) with env ARMADA_RELEASE_VERSION=0.3.103 kubectl apply -n armada -f ./dev/quickstart/armada-crds.yaml (this is the standard step as we specify in the README) but the server always responded with Invalid value: "$ARMADA_RELEASE_VERSION": spec.image.tag in body should match '^[a-zA-Z0-9_.-]*$' errors. Kubectl doesn't seem to expand env vars for input files nor propagate them to the server for processing, so we would have to add some sort of preprocessing, we could have the actual kubectl apply be done as a Makefile target instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants