Remove redundant assignment to isSchedulable

armadaproject · Jun 27, 2023 · 0d82d1f · 0d82d1f
1 parent cc23cbe
commit 0d82d1f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/internal/scheduler/submitcheck.go b/internal/scheduler/submitcheck.go
@@ -214,17 +214,17 @@ func (srv *SubmitChecker) getSchedulingResult(jctxs []*schedulercontext.JobSched
 		nodeDb := executor.nodeDb
 		txn := nodeDb.Txn(true)
 		ok, err := nodeDb.ScheduleManyWithTxn(txn, jctxs)
-		isSchedulable = isSchedulable || ok
 		txn.Abort()
 
+		isSchedulable = isSchedulable || ok
+
 		sb.WriteString(id)
 		if err != nil {
 			sb.WriteString(err.Error())
 			sb.WriteString("\n")
 			continue
 		}
 
-		isSchedulable = isSchedulable || ok
 		numSuccessfullyScheduled := 0
 		for _, jctx := range jctxs {
 			pctx := jctx.PodSchedulingContext