Add streaming gRPC service to transfer jobs from the server to the executor #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesMurkin
reviewed
Jun 1, 2022
JamesMurkin
reviewed
Jun 1, 2022
JamesMurkin
reviewed
Jun 1, 2022
JamesMurkin
approved these changes
Jun 1, 2022
JamesMurkin
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we send jobs to the executor in batches using unary gRPC calls. If such a call fails due to network error, those jobs are in limbo until the leases expire, which may be a long time. The issue is that, for unary gRPC calls, the server has no way of knowing if sending a response back succeeded or not.
This PR adds a way of sending jobs over a bidirectional gRPC stream, where jobs are from the server to the executor and ids of received jobs are sent back to the server. Only acked jobs are marked as leased by the server.