Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python client: Improve docstrings, generate docs #1084

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

jayofdoom
Copy link
Contributor

  • Improves docstrings and makes them compliant with RST format
    expected by sphinx.
  • Adds configuration and automation for generating jekyll-markdown
    files from docstrings (for use with gh-pages)
  • Adds documenation on how to use the generation.

The docstrings in the code can still use significant improvement
as our understanding of the API and python types involved improve,
however this is better than what we have today and provides a basis
for future improvement.

First half of changes needed for #1027.

@jayofdoom jayofdoom force-pushed the client_doc_generation branch 2 times, most recently from d66d6ab to edc2ddb Compare June 15, 2022 18:42
@jayofdoom jayofdoom force-pushed the client_doc_generation branch 2 times, most recently from 4fe936f to d601845 Compare June 15, 2022 18:54
kannon92
kannon92 previously approved these changes Jun 15, 2022
client/python/armada_client/client.py Outdated Show resolved Hide resolved
- Improves docstrings and makes them compliant with RST format
  expected by sphinx.
- Adds configuration and automation for generating jekyll-markdown
  files from docstrings (for use with gh-pages)
- Adds documenation on how to use the generation.

The docstrings in the code can still use significant improvement
as our understanding of the API and python types involved improve,
however this is better than what we have today and provides a basis
for future improvement.

First half of changes needed for armadaproject#1027.
@severinson severinson merged commit 0a31b90 into armadaproject:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants