Expose grpc keepalive params in config #1094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose GRPC keepalive parameters via Armada configuration (definitions can be found here). The motivation here is to allow users to tweak these parameters based on their particular Armada deployment (e.g. to increase the ping frequency for quicker notification of transport failures at the expense of server load).
ServerParameters.MaxConnectionIdle
ServerParameters.MaxConnectionAge
ServerParameters.MaxConnectionAgeGrace
ServerParameters.Time
ServerParameters.Timeout
EnforcementPolicy.MinTime
EnforcementPolicy.PermitWithoutStream
I've added default values to
config/armada/config.yaml
,config/lookout/config.yaml
andconfig/binoculars/config.yaml
[1] so that all values will be defaulted to the values that were set in previous releases.[1] I've omitted
ServerParameters.MaxConnectionAge
andServerParameters.MaxConnectionAgeGrace
from the default values as these would need to be set to eitherint64.maxValue
or0s
to maintain the current behaviour, which I think is a bit cryptic. Instead by leaving them unset they will default to 0, which the grpc lib will treat as unset and apply the default value of infinity.