Fix when GHAs run #1110
Merged
Fix when GHAs run #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aiming to make it run on pushes of all branches (except master, which do not need to run tests after merge -- this will change when releasing is moved to GHA). Should also fix issue where PRs from forks don't have the job runners show up in the list at the bottom of the pull request. Related: Issue armadaproject#1037
kannon92
suggested changes
Jun 22, 2022
|
The only opportunity to DRY up, AFAICT, would be using yaml anchors to make us only list the paths once per workflow. That adds a bit of complexity (someone reading this file has to grok yaml anchors) for very minimal benefit. I would go the route of DRYing it up if I could do it across github workflows. If you feel strongly about it; I can use the yaml anchors but for small config snippets like this, I find the readability of being explicit worth the tradeoff. |
jayofdoom
commented
Jun 22, 2022
kannon92
approved these changes
Jun 22, 2022
JamesMurkin
approved these changes
Jun 22, 2022
jimbobby5
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming to make it run on pushes of all branches (except master, which
do not need to run tests after merge -- this will change when releasing
is moved to GHA).
Should also fix issue where PRs from forks don't have the job runners
show up in the list at the bottom of the pull request.
Related: Issue #1037