add healthcheck in testsuite for armada server #1120
Conversation
| @@ -17,6 +22,7 @@ import ( | |||
|
|
|||
| type ApiConnectionDetails struct { | |||
| ArmadaUrl string | |||
| ArmadaRestUrl string | |||
There was a problem hiding this comment.
Is it possible to just construct the ArmadaRestUrl from ArmadaUrl?
I don't love a new config value that requires our client users to put both a RestURL and a grpc URL.
There was a problem hiding this comment.
No. They may be completely different.
There was a problem hiding this comment.
So how does someone understand what to put for ArmadaRestUrl?
This is a config that our users of armadactl and other client libs use so I don't understand how they would know that the RestURL that grpc is generating could be very different from the connection details they would use for the internal grpc server.
There was a problem hiding this comment.
@kannon92 grpc and rest could quite possibly be on completely different (sub)domains, where the REST server exposes "safe" endpoints and could be made public, and the gRPC server exposes "unsafe/admin" endpoints, and could be made private.
cmd/testsuite/cmd/test.go
Outdated
| testSuites.AddSuite(*testSuite) | ||
| if junitPath != "" { | ||
| if err := createJUnitReport(junitPath, testSuites); err != nil { | ||
| return errors.Wrap(err, "error creating junit report") |
There was a problem hiding this comment.
| return errors.Wrap(err, "error creating junit report") | |
| return errors.WithMessage(err, "error creating junit report") |
No description provided.