trim columns for lookout #1245
Merged
trim columns for lookout #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesMurkin
previously approved these changes
Jul 26, 2022
JamesMurkin
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1099
In summary, lookout ui allows user inputs for job-sets, jobId queue and owner. There is a possibility for a user to add whitespace to end and we fail to lookout that job in a table.
This PR addresses this by trimming the user input so the lookout service can grab the jobs.
There are two changes in the JobService.ts and the JobQueryService that trim the whitespace.
@JamesMurkin and @carlocamurri Why do we allow arrays for JobSets? I only added trimming to objects that are pure strings. JobSets are an array of strings so I'm unsure.