Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled Dependabot for Python packages (#1227) #1251

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

AgataGans
Copy link
Contributor

@AgataGans AgataGans commented Jul 21, 2022

  • Added Dependabot integration for pip

#1227

Copy link
Contributor

@jayofdoom jayofdoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing, there's a comment that'll need resolution.

Where'd you find us? Is there any general interest in Armada beyond just this contribution?


# Enable version updates for pip
- package-ecosystem: "pip"
directory: "/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have two python modules in this repo:

  • one under client/python
  • one under third_party/airflow

IMBW, but I believe this will have to be pointed at the module dirs directly (where the pyproject.toml is) in order for this to be effective.

Copy link
Contributor Author

@AgataGans AgataGans Jul 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the required changes. Unfortunately, it's still impossible to add multiple dirs into the same package ecosystem.
Here's what I found on this:
dependabot/dependabot-core#2824
iZettle/example-integration#7

However, I think that my version was correct - it should have been checking all python packages in the whole root dir. At least accrording to what I've read so far. IMBW, too, of course. It's something for me to learn more about, for sure!


I was looking for some open source projects I could contribute to for the first time and to practice using GitHub, and this way I found Armada.
I'm actually trying to learn more about Armada itself rn. : )

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the revision is better; I prefer being explicit about where to check.

Thanks for coming by! If you have any questions, feel free to pop them into github discussions. Otherwise, if you continue to be interested in contributing, please just pick up an untouched issue and comment on it. Those of us working full time on Armada work right out of github issues, so that should be up to date.

* Added Dependabot integration for pip
@jayofdoom jayofdoom enabled auto-merge (squash) July 22, 2022 14:30
@jayofdoom jayofdoom merged commit da6ca9f into armadaproject:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants