Go setup is useless without matrix set #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayofdoom
force-pushed
the
jay/FixPythonGoSetup
branch
from
85d0452
to
e0b6681
Compare
Before this change, the go-setup include in python was a noop due to a missing go version identifier, and the include was completely missing from the airflow operator. Issue armadaproject#1142
jayofdoom
force-pushed
the
jay/FixPythonGoSetup
branch
from
e0b6681
to
53147a2
Compare
kannon92
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the go-setup include was a noop due to a missing
go version identifier and go-setup itself was missing from airflow-operator.yml.
These jobs only need go to generate the python files from the proto files. Any
version of go we support will work; so I use 1.18 to future proof it. No need to matrix
python tests on go versions :).
Issue #1142