1494 lookout use orig job spec #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 19, 2022 11:35
suprjinx
commented
Oct 20, 2022
suprjinx
commented
Oct 20, 2022
kannon92
reviewed
Oct 20, 2022
internal/lookout/repository/jobs.go
Outdated
| if err != nil { | ||
| log.Errorf("error while parsing job %s json: %v", ParseNullString(row.JobId), err) | ||
| log.Warnf("unable to load orig job spec. %+v", err) |
There was a problem hiding this comment.
not sure why i changed that, will switch back
suprjinx
commented
Oct 20, 2022
| @@ -979,7 +980,7 @@ func getPriority(t *testing.T, db *goqu.Database, jobId string) float64 { | |||
|
|
|||
| func getJob(t *testing.T, db *goqu.Database, jobId string) *api.Job { | |||
| var job api.Job | |||
| jobJson := ParseNullString(selectNullString(t, db, fmt.Sprintf("SELECT job FROM job WHERE job_id = '%s'", jobId))) | |||
| jobJson := ParseNullString(selectNullString(t, db, fmt.Sprintf("SELECT orig_job_spec FROM job WHERE job_id = '%s'", jobId))) | |||
There was a problem hiding this comment.
this should probably switch to proto marshall/unmarshall instead of jamming json in there
kannon92
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1494