Add per-priority class default tolerations #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d80tb7
approved these changes
Oct 21, 2022
severinson
commented
Oct 21, 2022
| } | ||
| for _, defaultToleration := range server.schedulingConfig.DefaultJobTolerations { | ||
| podToleration, ok := podTolerations[defaultToleration.Key] | ||
| if !ok || !defaultToleration.MatchToleration(&podToleration) { |
There was a problem hiding this comment.
This is an optimisation to avoid adding redundant tolerations. I don't think it's necessary and have removed it. This optimisation would not even remove all duplicate taints. Since there may be several tolerations with the same key.
There was a problem hiding this comment.
Duplicate tolerations should we safe. Since the code that checks for tolerations just loops over the existing tolerations to check if any of them tolerates a given taint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.