-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Job Deletion Logic To Support Force Kill #1694
Conversation
client.Fake.ClearActions() | ||
clusterContext.DeletePods([]*v1.Pod{pod}) | ||
clusterContext.ProcessPodsToDelete() | ||
assert.Equal(t, len(client.Fake.Actions()), 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I want to assert that we using a timout of 0 to kill the pod, but it doesn't look like the fake client tells me this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look, I can't see how to get the options passed to the delete call either :(
Possibly google may have some ideas
This changes the executor's job deletion logic so that: