Fix PrevRedisId when SeqNo is 0 #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently from id `1666953497076:0:1:0` gets converted to `1666953497076--1` as we do `newSeqNo = currentSeqNo - 1` which falls down when then currentSeqNo is 0 To prevent this, I simply limit the numbers to non-negative values `
JamesMurkin
changed the title
d80tb7
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently from id
1666953497076:0:1:0gets converted to1666953497076--1as we donewSeqNo = currentSeqNo - 1which falls down when then currentSeqNo is 0The above behavior is a bug and we now avoid doing it with a better if statement