Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running executor with legacy api disabled #2369

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

JamesMurkin
Copy link
Contributor

@JamesMurkin JamesMurkin commented Apr 14, 2023

This PR just makes it so UseLegacyApi is set to false, no components used with the legacy api are used

┆Issue is synchronized with this Jira Task by Unito

This PR just makes it so UseLegacyApi is set to false, no components used with the legacy api are used
@JamesMurkin JamesMurkin marked this pull request as ready for review April 14, 2023 11:22
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.34 ⚠️

Comparison is base (85fdace) 59.30% compared to head (c204879) 58.97%.

❗ Current head c204879 differs from pull request most recent head 88ad297. Consider uploading reports for the commit 88ad297 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2369      +/-   ##
==========================================
- Coverage   59.30%   58.97%   -0.34%     
==========================================
  Files         226      225       -1     
  Lines       28834    28472     -362     
==========================================
- Hits        17101    16790     -311     
+ Misses      10423    10390      -33     
+ Partials     1310     1292      -18     
Flag Coverage Δ
armada-server 58.97% <0.00%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/executor/application.go 7.52% <0.00%> (-0.06%) ⬇️

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JamesMurkin JamesMurkin enabled auto-merge (squash) April 26, 2023 11:25
@JamesMurkin JamesMurkin merged commit 29194ab into master Apr 26, 2023
@JamesMurkin JamesMurkin deleted the fix_legacy_executor_startup branch August 24, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants