Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler side cluster metrics #2415

Merged
merged 21 commits into from
May 12, 2023
Merged

Scheduler side cluster metrics #2415

merged 21 commits into from
May 12, 2023

Conversation

JamesMurkin
Copy link
Contributor

@JamesMurkin JamesMurkin commented May 1, 2023

┆Issue is synchronized with this Jira Task by Unito

@JamesMurkin JamesMurkin added the do-not-merge Do not merge this PR label May 1, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 63.42% and project coverage change: +0.02 🎉

Comparison is base (5c14fd1) 58.46% compared to head (e535272) 58.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2415      +/-   ##
==========================================
+ Coverage   58.46%   58.49%   +0.02%     
==========================================
  Files         235      235              
  Lines       29314    29436     +122     
==========================================
+ Hits        17139    17218      +79     
- Misses      10858    10899      +41     
- Partials     1317     1319       +2     
Flag Coverage Δ
armada-server 58.49% <63.42%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/common/metrics/scheduler_metrics.go 0.00% <0.00%> (ø)
...ternal/executor/utilisation/cluster_utilisation.go 39.08% <0.00%> (-2.00%) ⬇️
internal/scheduler/schedulerapp.go 0.00% <0.00%> (ø)
internal/scheduler/schedulerobjects/node.go 0.00% <0.00%> (ø)
internal/scheduler/metrics.go 79.48% <92.50%> (+10.39%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JamesMurkin JamesMurkin marked this pull request as ready for review May 3, 2023 22:04
@JamesMurkin JamesMurkin removed the do-not-merge Do not merge this PR label May 3, 2023
@JamesMurkin JamesMurkin changed the title [WIP] Scheduler side cluster metrics Scheduler side cluster metrics May 3, 2023
d80tb7
d80tb7 previously approved these changes May 8, 2023
# Conflicts:
#	internal/executor/utilisation/cluster_utilisation.go
#	internal/scheduler/schedulerobjects/schedulerobjects.pb.go
#	internal/scheduler/schedulerobjects/schedulerobjects.proto
#	pkg/api/queue.pb.go
#	pkg/api/queue.proto
#	pkg/api/util.go
@JamesMurkin JamesMurkin merged commit b8df46e into master May 12, 2023
44 checks passed
@JamesMurkin JamesMurkin deleted the f/chrisma/more-metrics branch May 12, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants