Make fake executor support cancellation #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now track which pods are allocated to each node, so we can deallocate them correctly on cancellation Previously cancelled pods would just remain allocated forever and block all capacity on the cluster
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2422 +/- ##
=======================================
Coverage 58.56% 58.56%
=======================================
Files 231 231
Lines 28813 28813
=======================================
Hits 16875 16875
Misses 10636 10636
Partials 1302 1302
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d80tb7
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now track which pods are allocated to each node, so we can deallocate them correctly on cancellation
Previously cancelled pods would just remain allocated forever and block all capacity on the cluster
┆Issue is synchronized with this Jira Task by Unito