Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip jobs with requirements known to be unfeasible #2436

Merged
merged 19 commits into from
May 11, 2023

Conversation

severinson
Copy link
Contributor

@severinson severinson commented May 8, 2023

This results in about a factor 2 speedup of the overall scheduling cycle for a particular scenario:

go.exe test -benchmem -run=^$ -bench ^BenchmarkPreemptingQueueScheduler$ github.com/armadaproject/armada/internal/scheduler
goos: windows
goarch: amd64
pkg: github.com/armadaproject/armada/internal/scheduler
cpu: 12th Gen Intel(R) Core(TM) i7-12700H

# With this optimisation
BenchmarkPreemptingQueueScheduler/10_nodes_10_queues_3200_jobs-20                      7         172808914 ns/op        74964281 B/op    1841731 allocs/op

# Without this optimisation
BenchmarkPreemptingQueueScheduler/10_nodes_10_queues_3200_jobs-20                      3         380257833 ns/op        240220352 B/op   4249353 allocs/op

┆Issue is synchronized with this Jira Task by Unito

@severinson severinson marked this pull request as ready for review May 8, 2023 13:58
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 69.69% and project coverage change: +0.01 🎉

Comparison is base (7b8b18f) 58.47% compared to head (e3f1673) 58.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2436      +/-   ##
==========================================
+ Coverage   58.47%   58.49%   +0.01%     
==========================================
  Files         234      234              
  Lines       29241    29296      +55     
==========================================
+ Hits        17099    17136      +37     
- Misses      10828    10844      +16     
- Partials     1314     1316       +2     
Flag Coverage Δ
armada-server 58.49% <69.69%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/armada/server/lease.go 7.74% <0.00%> (-0.07%) ⬇️
internal/scheduler/preempting_queue_scheduler.go 64.68% <0.00%> (-0.53%) ⬇️
internal/scheduler/queue_scheduler.go 66.54% <0.00%> (-0.48%) ⬇️
internal/scheduler/scheduling_algo.go 65.83% <0.00%> (-0.63%) ⬇️
internal/scheduler/schedulerobjects/podutils.go 62.83% <66.66%> (ø)
internal/scheduler/gang_scheduler.go 90.83% <95.45%> (+1.94%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@severinson severinson enabled auto-merge (squash) May 11, 2023 10:54
@severinson severinson merged commit 79d2202 into master May 11, 2023
32 checks passed
@severinson severinson deleted the severinson/scheduling-key-cache branch May 11, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants