Only call GetJobSetEvents once #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2442 +/- ##
=======================================
Coverage 58.48% 58.48%
=======================================
Files 234 234
Lines 29239 29241 +2
=======================================
+ Hits 17099 17103 +4
+ Misses 10827 10826 -1
+ Partials 1313 1312 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
richscott
reviewed
May 10, 2023
| @@ -82,6 +82,17 @@ func (eventToJobService *EventsToJobService) streamCommon(ctx context.Context, t | |||
| } | |||
| }() | |||
|
|
|||
| log.Infof("GetJobEventMessage for %s/%s with id %s", eventToJobService.queue, eventToJobService.jobSetId, fromMessageId) | |||
There was a problem hiding this comment.
Are Daniele and/or others comfortable with info-level logging on this, or would they prefer it to be debug-level?
There was a problem hiding this comment.
I think it would be fine as this should only be once every subscribe. But we can always mess around with this.
ClifHouck
approved these changes
May 10, 2023
richscott
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a GRPC stream you should get the stream and then start looping over that. Calling it a bunch is not ideal.
This is a POC for right now to test out if this actually works.
Thanks @d80tb7
┆Issue is synchronized with this Jira Task by Unito