Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unschedulable nodes in the scheduler #2449

Merged
merged 5 commits into from
May 12, 2023

Conversation

severinson
Copy link
Contributor

@severinson severinson commented May 11, 2023

┆Issue is synchronized with this Jira Task by Unito

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (0fd3091) 58.49% compared to head (26216a2) 58.45%.

❗ Current head 26216a2 differs from pull request most recent head a5986b4. Consider uploading reports for the commit a5986b4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2449      +/-   ##
==========================================
- Coverage   58.49%   58.45%   -0.04%     
==========================================
  Files         234      235       +1     
  Lines       29296    29316      +20     
==========================================
  Hits        17136    17136              
- Misses      10844    10862      +18     
- Partials     1316     1318       +2     
Flag Coverage Δ
armada-server 58.45% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/scheduler/nodedb/nodedb.go 58.77% <0.00%> (-0.30%) ⬇️
internal/scheduler/nodedb/unschedulable.go 0.00% <0.00%> (ø)
internal/scheduler/preempting_queue_scheduler.go 64.37% <0.00%> (-0.32%) ⬇️
internal/scheduler/schedulerobjects/node.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@severinson severinson marked this pull request as ready for review May 12, 2023 09:48
@severinson severinson merged commit e0ae881 into master May 12, 2023
33 of 34 checks passed
@severinson severinson deleted the severinson/cordoned-aware-scheduler branch May 12, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants