Add index on Job Service tables Timestamp column. #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To improve performance of the trigger-fired stored-proc to purge old jobsets table entries, by avoiding full table scans on each delete. Also, refactor the table creation logic to make more compact and eliminate repetition of db.Exec(), etc,.
kannon92
approved these changes
May 11, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2453 +/- ##
==========================================
- Coverage 58.50% 58.49% -0.02%
==========================================
Files 234 234
Lines 29296 29296
==========================================
- Hits 17140 17136 -4
- Misses 10842 10844 +2
- Partials 1314 1316 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Job Service database uses a trigger to invoke a small stored procedure to delete all entries in the
jobserviceandjobsetstables that have theirtimestampcolumn older than thepurgeTimeconfiguration value (value is in seconds). This trigger is fired upon each insert to thejobsetstable, so the deletes in this proc must be as fast as possible. This change adds an index to thetimestampcolumn of both tables. Manual testing shows a considerable speedup when the tables have 50k or more rows, usingEXPLAIN ANALYZE DELETE from .. WHERE....Also, refactor the table creation logic to make more compact and eliminate repetition of db.Exec(), etc,.
┆Issue is synchronized with this Jira Task by Unito