Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing context error #2459

Merged
merged 3 commits into from
May 14, 2023
Merged

Conversation

severinson
Copy link
Contributor

@severinson severinson commented May 12, 2023

┆Issue is synchronized with this Jira Task by Unito

@severinson severinson enabled auto-merge (squash) May 12, 2023 15:41
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (5cc1afb) 58.45% compared to head (3ff56bb) 58.47%.

❗ Current head 3ff56bb differs from pull request most recent head e429a78. Consider uploading reports for the commit e429a78 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2459      +/-   ##
==========================================
+ Coverage   58.45%   58.47%   +0.01%     
==========================================
  Files         235      235              
  Lines       29446    29447       +1     
==========================================
+ Hits        17212    17218       +6     
+ Misses      10912    10910       -2     
+ Partials     1322     1319       -3     
Flag Coverage Δ
armada-server 58.47% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/scheduler/queue_scheduler.go 66.31% <0.00%> (-0.24%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@severinson severinson merged commit 316cbf6 into master May 14, 2023
21 checks passed
@JamesMurkin JamesMurkin deleted the severinson/context-timeout-error-fix branch May 14, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants