Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reason for cancellation #2470

Merged
merged 29 commits into from
May 16, 2023
Merged

Conversation

carlocamurri
Copy link
Contributor

@carlocamurri carlocamurri commented May 15, 2023

Based on #2438

  • Ensures message is max 512 chars long
  • Fixes UI styling
  • Ensures reason is populated in JobCancelled event
  • Add tests
  • Ensures cancellation reason is not stored in Redis

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 46.66% and project coverage change: -0.03 ⚠️

Comparison is base (ed0ecaf) 58.47% compared to head (109eac6) 58.44%.

❗ Current head 109eac6 differs from pull request most recent head 739a9e8. Consider uploading reports for the commit 739a9e8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2470      +/-   ##
==========================================
- Coverage   58.47%   58.44%   -0.03%     
==========================================
  Files         235      235              
  Lines       29464    29521      +57     
==========================================
+ Hits        17230    17255      +25     
- Misses      10913    10947      +34     
+ Partials     1321     1319       -2     
Flag Coverage Δ
armada-server 58.44% <46.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/armada/server/submit_from_log.go 4.19% <0.00%> (-0.22%) ⬇️
internal/armada/server/submit_to_log.go 0.00% <0.00%> (ø)
internal/common/eventutil/eventutil.go 38.15% <0.00%> (-0.04%) ⬇️
internal/armada/server/submit.go 55.89% <80.00%> (+0.40%) ⬆️
internal/armada/server/reporting.go 64.34% <100.00%> (+0.47%) ⬆️
internal/common/util/batch.go 100.00% <100.00%> (ø)
internal/eventingester/convert/conversions.go 69.64% <100.00%> (+9.17%) ⬆️
...nal/lookoutingesterv2/instructions/instructions.go 75.31% <100.00%> (+0.41%) ⬆️
internal/lookoutingesterv2/lookoutdb/insertion.go 85.08% <100.00%> (+0.12%) ⬆️
internal/lookoutv2/conversions/convert.go 95.38% <100.00%> (+0.07%) ⬆️
... and 1 more

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@carlocamurri carlocamurri enabled auto-merge (squash) May 16, 2023 16:29
@carlocamurri carlocamurri merged commit 8011b0a into master May 16, 2023
31 of 32 checks passed
@carlocamurri carlocamurri deleted the carlocamurri/reason-for-cancellation branch May 22, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants