Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #2476

Merged
merged 6 commits into from
May 18, 2023
Merged

Update README.md #2476

merged 6 commits into from
May 18, 2023

Conversation

satyampsoni
Copy link
Contributor

@satyampsoni satyampsoni commented May 17, 2023

Added contributions section

Added contributions section
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.08 🎉

Comparison is base (8011b0a) 58.37% compared to head (ae68645) 58.45%.

❗ Current head ae68645 differs from pull request most recent head 7859fde. Consider uploading reports for the commit 7859fde to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2476      +/-   ##
==========================================
+ Coverage   58.37%   58.45%   +0.08%     
==========================================
  Files         235      235              
  Lines       29537    29537              
==========================================
+ Hits        17243    17267      +24     
+ Misses      10976    10949      -27     
- Partials     1318     1321       +3     
Flag Coverage Δ
armada-server 58.45% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

README.md Outdated Show resolved Hide resolved
satyampsoni and others added 2 commits May 17, 2023 20:27
Added  'Finding Issues to Work' On section in the contributing.md
Co-authored-by: Kevin Hannon <kannon1992@gmail.com>
kannon92
kannon92 previously approved these changes May 17, 2023
kannon92
kannon92 previously approved these changes May 17, 2023
@satyampsoni
Copy link
Contributor Author

Sorry, got confused over the branches. I have deleted those extra branches, is it fine now?

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Kevin Hannon <kannon1992@gmail.com>
Co-authored-by: Kevin Hannon <kannon1992@gmail.com>
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@kannon92 kannon92 enabled auto-merge (squash) May 18, 2023 12:09
@kannon92 kannon92 merged commit b37d1dd into armadaproject:master May 18, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants