Make lookout ingesters process PodUnschedulable errors #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation for this change is that we have many runs that never get the node name set - because this information is on the PodUnschedulable error events. This makes tracking if certain nodes have most of the issues very difficult, as most runs with errors don't get the node set This PR: - No longer skips non-terminal errors, this should be fine as: - The only events that are non-terminal are PodUnschedulable and PodTerminated and the ingester handles both of these explicitly - Each event will only have 1 error - Set the nodeName on PodUnschedulable error events Longer term this flow needs more thought: - Possibly add a PodNodeAssigned event - Possibly add other events to display start up status - Add NodeName to other events However for now this is a minimal change to help with investigation into problem nodes
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2478 +/- ##
==========================================
+ Coverage 58.45% 58.50% +0.04%
==========================================
Files 235 235
Lines 29537 29526 -11
==========================================
+ Hits 17267 17273 +6
+ Misses 10949 10932 -17
Partials 1321 1321
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
carlocamurri
previously approved these changes
May 18, 2023
JamesMurkin
commented
May 18, 2023
carlocamurri
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this change is that we have many runs that never get the node name set - because this information is on the PodUnschedulable error events.
This makes tracking if certain nodes have most of the issues very difficult, as most runs with errors don't get the node set
This PR:
Longer term this flow needs more thought:
However for now this is a minimal change to help with investigation into problem nodes
┆Issue is synchronized with this Jira Task by Unito