Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix release ci #2589

Merged
merged 26 commits into from
Jul 6, 2023
Merged

Conversation

dejanzele
Copy link
Member

@dejanzele dejanzele commented Jun 20, 2023

Fixes #

Special notes for your reviewer:

┆Issue is synchronized with this Jira Task by Unito

@dejanzele dejanzele requested a review from richscott June 20, 2023 00:50
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +18.30 🎉

Comparison is base (9a1ab98) 16.07% compared to head (1f13228) 34.38%.

❗ Current head 1f13228 differs from pull request most recent head 9699756. Consider uploading reports for the commit 9699756 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2589       +/-   ##
===========================================
+ Coverage   16.07%   34.38%   +18.30%     
===========================================
  Files         159      112       -47     
  Lines       12490     3467     -9023     
  Branches      470      470               
===========================================
- Hits         2008     1192      -816     
+ Misses      10320     2192     -8128     
+ Partials      162       83       -79     
Flag Coverage Δ
unittests 34.38% <ø> (+18.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 47 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

suprjinx
suprjinx previously approved these changes Jun 20, 2023
Copy link
Contributor

@suprjinx suprjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

richscott
richscott previously approved these changes Jun 20, 2023
@dejanzele dejanzele dismissed stale reviews from richscott and suprjinx via 45e1c9e June 28, 2023 14:34
.github/workflows/release-rc.yml Fixed Show fixed Hide fixed
.github/workflows/release.yml Fixed Show fixed Hide fixed
.github/workflows/release-rc.yml Dismissed Show resolved Hide resolved
.github/workflows/release.yml Dismissed Show resolved Hide resolved
dejanzele and others added 5 commits July 5, 2023 16:33
Co-authored-by: Albin Severinson <albin@severinson.org>
Co-authored-by: JamesMurkin <jamesmurkin@hotmail.com>
Co-authored-by: Carlo Camurri <carlo.camurri98@gmail.com>
Co-authored-by: Noah Held <41909795+zuqq@users.noreply.github.com>
Co-authored-by: Rich Scott <rich@gr-oss.io>
Co-authored-by: Jay Faulkner <jay@jvf.cc>
Co-authored-by: Adam McArthur <46480158+Sharpz7@users.noreply.github.com>
Co-authored-by: Kevin Hannon <kannon1992@gmail.com>
.github/workflows/release-rc.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release-rc.yml Outdated Show resolved Hide resolved
.github/workflows/release-rc.yml Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release-rc.yml Outdated Show resolved Hide resolved
@dejanzele dejanzele requested a review from jgiannuzzi July 6, 2023 13:25
.github/workflows/release-rc.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
Copy link
Member

@jgiannuzzi jgiannuzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

could you please post links to a release and a release-rc run on your fork? (you'll need these changes to be in your default branch for it to work)

@dejanzele dejanzele enabled auto-merge (squash) July 6, 2023 15:00
@dejanzele dejanzele merged commit e061b91 into armadaproject:master Jul 6, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants