feat: add new test workflow #2602
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2602 +/- ##
===========================================
- Coverage 58.77% 16.07% -42.71%
===========================================
Files 238 159 -79
Lines 30477 12490 -17987
Branches 0 470 +470
===========================================
- Hits 17914 2008 -15906
+ Misses 11216 10320 -896
+ Partials 1347 162 -1185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
… feat/test-workflow
|
Our required workflows are looking for |
… feat/test-workflow
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| branches-ignore: | ||
| - gh-pages | ||
| schedule: | ||
| # Run daily at 01:34, so we get notified if CI is broken before a pull request |
There was a problem hiding this comment.
Is there a reason for this exact time?
| path: ./internal/lookout/ui/junit.xml | ||
| if-no-files-found: error | ||
|
|
||
| - name: Send Coverage Report to Codecov |
There was a problem hiding this comment.
Are we able to test that this produces the results we expect? (General question about all code coverages together)
There was a problem hiding this comment.
| ./internal/jobservice/repository/... 2>&1 | tee -a test_reports/internal.txt | ||
| $(GOTESTSUM) -- -coverprofile pkg_coverage.xml -v ./pkg... 2>&1 | tee test_reports/pkg.txt | ||
| $(GOTESTSUM) -- -coverprofile cmd_coverage.xml -v ./cmd... 2>&1 | tee test_reports/cmd.txt | ||
| $(GOTESTSUM) --format short-verbose --junitfile test-reports/unit-tests.xml --jsonfile test-reports/unit-tests.json -- -coverprofile=test-reports/coverage.out -covermode=atomic ./cmd/... ./pkg/... $(go list ./internal/... | grep -v 'jobservice/repository') |
There was a problem hiding this comment.
Can we get this moved to mage? Even if its just a simple command that is run?
|
Have the intergration tests been changed in any way? I had it run consistently at 6-7 mins, it seems to be taking longer than that. |
|
not in this PR |
Fixes #
Special notes for your reviewer:
┆Issue is synchronized with this Jira Task by Unito