Stop serving version 1 of the Lookout UI #3040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noah Held <noahheld17@gmail.com>
|
I would want to see this correctly be completed in our "localdev" setup from mage.
|
d80tb7
approved these changes
Oct 16, 2023
This PR only touches the Lookout UI, so it is fully compatible with the existing setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the part of #3038 that only touches the Lookout UI, without changing either of the Lookout APIs.
On
master, the Lookout UI has a navigation bar with four tabs, and/is routed to the "overview" tab:This PR removes the tabs and routes
/to version 2 of the Lookout UI (which is accessible via the "v2" tab onmaster):This means that version 1 of the Lookout UI won't be accessible anymore, but I'm not deleting its code just yet.
In order to make the migration easier for our users, I'm redirecting
/v2to/(being careful to preserve the query string), which means that existing links to version 2 of the Lookout UI will continue to work; I'm also adding a wildcard route (it just redirects to/), so that links to/job-setsor/jobs(corresponding to the "job sets" and "jobs" tabs) don't just show a mostly blank page.