Lookout API record Job state in database #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankaspar
reviewed
Feb 19, 2021
| @@ -0,0 +1,7 @@ | |||
| ALTER TABLE job ADD COLUMN state smallint NULL; | |||
There was a problem hiding this comment.
It might be worth to set correct state for currently existing jobs as part of the migration, unless it is supper hard. You could then make it not null.
JamesMurkin
approved these changes
Feb 23, 2021
jankaspar
approved these changes
Feb 23, 2021
carlocamurri
deleted the
carlocamurri/lookout-api-record-job-state-in-db
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, each Job event received results in multiple fields being updated in the database (e.g. event firing time). A Job's state is computed at query time. This may result in some Jobs being recognised as having the wrong state, and/or slower database queries.
The proposed solution is to add Job state as a field in the
jobtable, and update it accordingly for individual Jobs as events are received. As a result, most queries are simplified.Note that multiple updates may be performed for some events.