Improve JobFailedEvent messages #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now properly reports pod level errors - Such as evicted Now contains ContainerStatuses - In the same way Kubernetes does for now (i.e not always present, depends on failure). We could just generate a status for every container - Status contains "Message" field which contains custom error messages send to /dev/termination-log, the same as the message field in kubernetes Now contains Pod level and container level (when present) Cause enum, which tries to give a summary idea of the pod/container failure cause. We can extend this more causes in the future (node failure etc).
jankaspar
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now properly reports pod level errors
Now contains ContainerStatuses
Now contains Pod level and container level (when present) Cause enum, which tries to give a summary idea of the pod/container failure cause. We can extend this more causes in the future (node failure etc).