armadactl refactor and testing #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate automated testing
…rvices started in makefile
carlocamurri
reviewed
Dec 3, 2021
carlocamurri
reviewed
Dec 3, 2021
d80tb7
reviewed
Dec 3, 2021
…ing up/tearing down an Armada cluster
d80tb7
previously approved these changes
Dec 3, 2021
d80tb7
approved these changes
Dec 3, 2021
carlocamurri
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the business logic of armadactl into
internal/armadactland introduces a way to easily capture its output to facilitate automated testing. This PR also introduces several automated tests for armadactl. For these tests, armadactl is run against an Armada server that is automatically spun up in a Docker container.