Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions that i have #22

Closed
cyprusglobe opened this issue Nov 14, 2013 · 8 comments
Closed

Questions that i have #22

cyprusglobe opened this issue Nov 14, 2013 · 8 comments

Comments

@cyprusglobe
Copy link
Contributor

so i have been wondering this for awhile and now i'm going to spit it out so i can get it off my mind so here it goes

currently i have been wondering why we have a dashboard app and a server app
wouldn't it make more sense to make these into 1 app ?

that way the dashboard could talk to the database just a though and a question

i think it would make it easier on us if we go this route but that is just me

wondering what you guys think about this

@cyprusglobe
Copy link
Contributor Author

Also another question here is currently we are using just plain peewee for the database stuff
i got to looking around and i found this

http://flask-peewee.readthedocs.org/en/latest/

@cyprusglobe
Copy link
Contributor Author

wondering if this would benefit us

@fsiddi
Copy link
Contributor

fsiddi commented Nov 15, 2013

The reason why we have two separate applications for dashboard an server is to allow the server to be neutral and only focused on jobs creation and distribution. This means that:

  • in the future OS native dashboards could be created
  • the API for talking to the database (and interacting with the server) is very simple
  • in some cases that might bring some redundancy (getting a list of clients as JSON into the dashboard, parsing that JSON and augmenting it with frontend-specific data and then exposing it to the user) but I think it's acceptable because of the previous point

I think the current design is strong enough and there is no need to merge server and dashboard.

The reason why we are not using flask-peewee is that it's overkill for us. What we need to do with the database is simple enough that we can just use native peewee (no need for additional interfaces at the moment). So, we won't benefit from flask-peewee at the moment.

@cyprusglobe
Copy link
Contributor Author

I totally understand that

i have also been wondering this

if we send json as of right now would it be better to do this

for the api side
https://flask-restless.readthedocs.org/en/latest/

@fsiddi
Copy link
Contributor

fsiddi commented Nov 15, 2013

Yes, I've looked into that. This implies:

  • switching ORM
  • adding another dependency to the project

I'd rather avoid this and focus on getting brender working with what we've got.

@cyprusglobe
Copy link
Contributor Author

sounds good :)

@cyprusglobe
Copy link
Contributor Author

yea that makes sense i would like to avoid this as much as possible too

@fsiddi
Copy link
Contributor

fsiddi commented Dec 13, 2013

We have made a mailing list for this, so this discussion can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants