Fix Xcode 12 errors #170
Closed
Fix Xcode 12 errors #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ORSSerialPort.h one extra { add in last commit in - (instancetype)initWithDevice:(io_object_t)device; Line armadsen#163
Explained: ORSSerial/ORSSerialPacketDescriptor.h file not found in issue armadsen#169
defined the following in ORSSerialPort.h
// defined missing interface to fix XCODE 12.3 errors.
+ (io_object_t) deviceFromBSDPath:(NSString *)bsdPath;
+ (NSString *) bsdCalloutPathFromDevice:(io_object_t)aDevice;
+ (NSString *) modemNameFromDevice:(io_object_t)aDevice;
/**
* ORSSerialPort must be init'd using -initWithPath:
*/
- (instancetype) init;
- (void) reallyClosePort;
- (void) notifyDelegateOfPosixError;
- (void) notifyDelegateOfPosixErrorWaitingUntilDone:(BOOL)shouldWait;
- (void) setPortOptions;
- (void) updateModemLines;
- (void) receiveData:(NSData *)data;
|
Thanks for this. Not using the framework is no longer officially supported, because it's complicated to correctly include framework headers from other framework headers while also supporting non-framework usage. I have fixed the build failure due to the extra brace on master. I'm going to close this, but I appreciate your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ORSSerialPort.h one extra { add in last commit in - (instancetype)initWithDevice:(io_object_t)device; Line #163
Explained: ORSSerial/ORSSerialPacketDescriptor.h file not found in issue #169
defined the following in ORSSerialPort.h
// defined missing interface to fix XCODE 12.3 errors.
/*
*/
(instancetype) init;
(void) reallyClosePort;
(void) notifyDelegateOfPosixError;
(void) notifyDelegateOfPosixErrorWaitingUntilDone:(BOOL)shouldWait;
(void) setPortOptions;
(void) updateModemLines;
(void) receiveData:(NSData *)data;