Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail Gcp4sLiveSuite early if no credentials #225

Merged
merged 4 commits into from
Jul 26, 2023
Merged

Conversation

valencik
Copy link
Collaborator

Previously if there was no SERVICE_ACCOUNT_CREDENTIALS environment variable the end-to-end tests would fail but only after munit timed out 30 seconds later.

This PR changes things to fail sooner and with a more direct error message:

gcp4s.bigquery.EndToEndSuite:                                                                                                                         
==> X gcp4s.bigquery.EndToEndSuite.projects contains project id  0.076s
  java.lang.Exception: Could not find 'SERVICE_ACCOUNT_CREDENTIALS' in ENV  

Co-authored-by: Arman Bilge <armanbilge@gmail.com>
@valencik valencik self-assigned this Jul 26, 2023
@valencik valencik requested a review from armanbilge July 26, 2023 19:09
@armanbilge armanbilge merged commit e2231c9 into main Jul 26, 2023
7 checks passed
@armanbilge armanbilge deleted the fix-test-hanging branch July 26, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants