provide more exhaustive message in validation

armandostyl · Feb 5, 2019 · 0327ffe · 0327ffe
1 parent d7f653d
commit 0327ffe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/plugin.info.txt b/plugin.info.txt
@@ -1,7 +1,7 @@
 base   structgroup
 author Szymon Olewniczak
 email  it@rid.pl
-date   2018-09-08
+date   2019-02-05
 name   Struct Group
 desc   New struct type - dokuwiki user groups
 url    https://dokuwiki.org/plugin:structgroup
diff --git a/types/Group.php b/types/Group.php
@@ -19,7 +19,7 @@ class Group extends AbstractMultiBaseType {
 
     /**
      * @param string $rawvalue the user to validate
-     * @return int|string|void
+     * @return int|string
      */
     public function validate($rawvalue) {
         $rawvalue = parent::validate($rawvalue);
@@ -29,7 +29,8 @@ public function validate($rawvalue) {
             $authgroup = plugin_load('helper', 'structgroup_authgroup');
 
             if(! in_array($rawvalue, $authgroup->getGroups())) {
-                throw new ValidationException('Group not found', $rawvalue);
+                throw new ValidationException('Group not found: "' . $rawvalue .
+                    '". Available groups: ' . implode(', ', $authgroup->getGroups()));
             }
         }