Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rockchip64 spidev overlay is not generic, needs renamed for rk3399 #5778

Closed
Tonymac32 opened this issue Oct 3, 2023 · 3 comments
Closed

Rockchip64 spidev overlay is not generic, needs renamed for rk3399 #5778

Tonymac32 opened this issue Oct 3, 2023 · 3 comments

Comments

@Tonymac32
Copy link
Member

Just putting this on the pile, since families have multiple SoC's this is not acceptable naming.

build/patch/kernel/archive/rockchip64-6.5/overlay/rockchip-spi-spidev.dts

Line 5 in 916c4f8

compatible = "rockchip,rk3399";

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Jira ticket: AR-1875

@Tonymac32
Copy link
Member Author

also affected are seemingly all other overlays not using a SoC prefix. this is a breaking change for any of the people lucky enough to be using them on an RK3399.

This was referenced Oct 3, 2023
Closed
Merged
@Tonymac32
Copy link
Member Author

solved with #5793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tonymac32