Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAID6_PQ should be disabled by default #696

Closed
PTDreamer opened this issue Jun 12, 2017 · 5 comments
Closed

RAID6_PQ should be disabled by default #696

PTDreamer opened this issue Jun 12, 2017 · 5 comments
Labels
Discussion Issue is being discussed. Undetermined.

Comments

@PTDreamer
Copy link

RAID6_PQ causes a boot delay of 3.5s on nanopineo. Furthermore even with menuconfig it is not obvious what should be disabled because since there is no help text associated with this configuration there is no easy was of knowing what other configurations depend on it.
Location: │ │ (2) -> Library routines │ │ Defined at lib/Kconfig:10 │ │ Selected by: MD_RAID456 [=m] && MD [=y] && BLK_DEV_MD [=m] || ORE [=n] && (EXOFS_FS [=n] || PNFS_OBJLAYOUT [=n]) || BTRFS_FS [=y] && BLOCK [=y]

@zador-blood-stained
Copy link
Member

"Selected by" shows exactly why this symbol was enabled.
And it's a hidden symbol, so it can't be controlled manually - it will be enabled automatically if any other option depends on it.

@zador-blood-stained
Copy link
Member

Also: #205

@PTDreamer
Copy link
Author

PTDreamer commented Jun 12, 2017

"Selected by" shows exactly why this symbol was enabled.
And it's a hidden symbol, so it can't be controlled manually - it will be enabled automatically if any other option depends on it.

The selected by doesn't show up because there is no help text on the kconfig. The text posted above was after adding some bogus help text.
EDIT: Just to make sure I get the message across, the configuration option "RAID6_PQ" doesn't show up while configuring the kernel because is has no help text associated. This isn't an issue because of the inability to disable it (because as you say it can't be controlled manually) but because it doesn't give you the list of options which depend on it and that indirectly allow you to disable it.

@zador-blood-stained
Copy link
Member

zador-blood-stained commented Jun 12, 2017

The selected by doesn't show up because there is no help text on the kconfig. The text posted above was after adding some bogus help text.

An easy way to find hidden options is using the menuconfig "search" function (/ key).
Example with an unmodified kernel:

Symbol: RAID6_PQ [=y]
Type  : tristate
  Defined at lib/Kconfig:10
  Selected by: MD_RAID456 [=m] && MD [=y] && BLK_DEV_MD [=m] || ORE [=n] && (EXOFS_FS [=n] || PNFS_OBJLAYOUT [=n]) || BTRFS_FS [=y] && BLOCK [=y]

(grepping Kconfig files for the option name is the hard way)

@PTDreamer
Copy link
Author

An easy way to find hidden options is using the menuconfig "search" function (/ key).

Full Ack

@igorpecovnik igorpecovnik added Discussion Issue is being discussed. Undetermined. and removed 0.question labels May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Issue is being discussed. Undetermined.
Development

No branches or pull requests

3 participants