Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncthing is configure to run as root when installed via armbian-config #18

Closed
PBRCW opened this issue Mar 9, 2018 · 4 comments
Closed

Comments

@PBRCW
Copy link

PBRCW commented Mar 9, 2018

When syncthing is installed via arbiam-config the installation is made so that the service is run as root. This is discouraged by the syncthing team, see here:
https://forum.syncthing.net/t/running-syncthing-as-root/6316
So this should be default configured for the usage of an unpriviledged user.

@ThomasKaiser
Copy link
Contributor

Yes, this says it all.

Running as root is irresponsible and needs to be changed (checking id, using ${SUDO_USER} for the whole stuff and asking which user account to choose in case the user directly logged in as root)

@igorpecovnik
Copy link
Member

Perhaps such implementation? https://github.com/armbian/config/blob/development/debian-config-submenu#L501-L521?

A part to create a new user/display error is missing.

@ThomasKaiser
Copy link
Contributor

I would check if ${SUDO_USER} contains a valid user name. If that's the case this user will be used otherwise a dialog with available user accounts should be presented as you suggested. If there's none (only root) then I would stop and tell the user to create an unprivileged user account being member of sudo group first and then try again.

@igorpecovnik
Copy link
Member

Service doesn't run as root, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants