Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer-Guide_Build-Options: Add warning about obsolescence #360

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

Kreyren
Copy link
Contributor

@Kreyren Kreyren commented Sep 7, 2023

Most of these options do not work or have potential to break the system such as the CRYPTROOT -> Advice against using it until it's updated

@viraniac
Copy link
Contributor

viraniac commented Sep 7, 2023

Most of these options do not work

Partially agree with this

have potential to break the system such as the CRYPTROOT

Whats wrong with CRYPTROOT? I just fixed it couple of months ago. Are you facing any issue with it? if yes, could you please share your build logs?

@Kreyren
Copy link
Contributor Author

Kreyren commented Sep 7, 2023

Whats wrong with CRYPTROOT? I just fixed it couple of months ago. Are you facing any issue with it? if yes, could you please share your build logs? -- @viraniac (#360 (comment))

For me when building olimex teres-a64 with full disk encryption it failed in a very dirty state and was pain to clean and make work again, try building the image on your end to see if you can reproduce that if not then i try to set up a container to test it 🤔

@igorpecovnik
Copy link
Member

For me when building olimex teres-a64 with full disk encryption it failed

Few months ago or today?

@Kreyren
Copy link
Contributor Author

Kreyren commented Sep 10, 2023

Few months ago or today? -- @igorpecovnik

~5 days ago

@viraniac
Copy link
Contributor

when building olimex teres-a64 with full disk encryption it failed in a very dirty state

@Kreyren Tried building on my machine just now. Builds fine, initrd contains all the files and hooks required to unlock cryptroot. I can't test if it boots cause I don't have the device. So you share your logs of failure or send me a teres a-64 to test things on.

@viraniac
Copy link
Contributor

viraniac commented Sep 10, 2023

@Kreyren in case you want to see my logs, check them here - https://paste.next.armbian.com/itixakicik

I do have some changes listed in the logs, but everything is related to Orange PI 3 LTS that I am trying to get into better state. Nothing related to cryptroot. Still builds fine

@EvilOlaf EvilOlaf added the stale label Dec 13, 2023
@igorpecovnik igorpecovnik merged commit 1b91887 into armbian:master Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants