Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mekotronics: drivers: rk_hdmirx: shut up spammy logs #14

Closed
wants to merge 1 commit into from

Conversation

rpardini
Copy link
Member

Couldn't find a better way.
If the HDMI-in is not plugged in, a lot of dmesg spam occurs - it can't lock the signal.
This is not only cosmetic, having an overflowing dmesg buffer can hamper the execution of sbc-bench, armbianmonitor etc.
This is solving it with a hammer, if anyone has a better idea?

@rpardini
Copy link
Member Author

This is indeed a terrible way. Removing the logs would cripple useful logging for actually working hdmirx on other boards.
Problem probably lies in det gpio on the R58's DTS. Since I've not the schematics for the boards, I could only speculate.

From chat history, thanks @amazingfate


amazingfate — Yesterday at 2:24 PM
I don't have hdmi rx spamming logs when the hdmi input source is not plugged on rock5b and another rk3588 board. Maybe we can investigate further.

rpardini — Yesterday at 2:27 PM
it is probably related to some missing pins in the Meko's DTS, but beyond my skillset
some det pin or such, which would signal "hey a thing is actually plugged in"

amazingfate — Yesterday at 2:31 PM
And maybe some interference. I got constantly hdmirx reset when both connected to hdmi input and wireless: https://forum.radxa.com/t/hdmi-in-frequently-reset/15760

rpardini — Yesterday at 2:34 PM
Yeah interference would explain errors if I had something pluggged in and it did not work...
I haven't plugged in anything yet
I was thinking maybe something here?

amazingfate — Yesterday at 3:54 PM
I will spend sometime to see when these logs will show up.

rpardini — Yesterday at 4:17 PM
Yeah don't waste much time; having non-flooded dmesg is pretty important but if all else fails I might just disable the hdmirx and add an overlay to enable it.
And super thanks for the help.


amazingfate — Today at 3:47 AM
the hdmirx driver will check the gpio to see if hdmi input is plugged: https://github.com/armbian/linux-rockchip/blob/rockchip-5.10/drivers/media/platform/rockchip/hdmirx/rk_hdmirx.c#L507
You can check if hdmirx_det_gpio is correctly configed in the device tree.

rpardini — Today at 3:59 AM
Yep, that's gotta be it. Thanks.

  • Rock-5b: hdmirx-det-gpios = <&gpio1 RK_PC6 GPIO_ACTIVE_LOW>;
  • Mekotronics: hdmirx-det-gpios = <&gpio1 29 GPIO_ACTIVE_LOW>; //gpio1_d5
  • Rock-5b: matches schematics https://dl.radxa.com/rock5/5b/docs/hw/radxa_rock_5b_v142_sch.pdf page 8
  • Mekotronics: which schematics?
    So yeah I'm gonna disable that hdmirx and add overlay for now.

@rpardini rpardini closed this Apr 15, 2023
@rpardini rpardini deleted the pr/rpardini/shutup-spammy-hdmirx branch May 15, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant