Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve empty result handling #81

Merged
merged 1 commit into from
Jul 6, 2019
Merged

Conversation

skjolber
Copy link
Contributor

@skjolber skjolber commented Jul 2, 2019

Make sure console output and report is written when there are features detected, but no vulernabilities.

Specific error code for when no features have been detected in the image.

@skjolber
Copy link
Contributor Author

skjolber commented Jul 2, 2019

@arminc seems like an error with the build?

$ goveralls -coverprofile=coverage.out -service=travis-ci -repotoken $COVERALLS_TOKEN
flag needs an argument: -repotoken
...
The command "goveralls -coverprofile=coverage.out -service=travis-ci -repotoken $COVERALLS_TOKEN" exited with 2.

@arminc
Copy link
Owner

arminc commented Jul 3, 2019

The build works on master (release) but somehow goveralls broke in the PR's. I haven't had time to fix it.
Regarding the PR: it looks good but I don't know if people deliberately check for exit 1 instead of not 0, if it the first one adding the extra exit code will mess up their workflow. I do agree that having distinction between the two is interesting.

@skjolber
Copy link
Contributor Author

skjolber commented Jul 3, 2019

I see your point about the error code, perhaps bump a minor version? The distinction between 'unsupported' and 'zero vulernabilities' is quite significant.

For your info, my use-case is the following:

  • collect a lot of images from running services in kubernetes
  • scan the images
  • upload scan result to a log backend
  • generate report in log backend

@arminc arminc merged commit 4641a0c into arminc:master Jul 6, 2019
@skjolber skjolber deleted the emptyResponse branch July 6, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants