Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependencies with cmsis-core #6

Closed
markus-becker-tridonic-com opened this issue Oct 8, 2015 · 6 comments
Closed

Circular dependencies with cmsis-core #6

markus-becker-tridonic-com opened this issue Oct 8, 2015 · 6 comments

Comments

@markus-becker-tridonic-com

Is it intentional that cmsis-core-k64f depends on cmsis-core? This creates a dependency loop, which makes it hard to make yotta use forked modules without forking the complete dependency tree.

At the moment the dependencies are:

\_ cmsis-core
  \_ cmsis-core-freescale
    \_ cmsis-core-k64f
       \_ cmsis-core

Shouldn't be it:

\_ cmsis-core
  \_ cmsis-core-freescale
    \_ cmsis-core-k64f

Then I could reversely depend in my application's module.json

      "cmsis-core-k64": "other-github-repo/cmsis-core-k64#master",
      "cmsis-core-freescale": "other-github-repo/cmsis-core-freescale#master",

without having to touch cmsis-core or rewriting each and every module.json of the various modules.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 8, 2015

@markus-becker-tridonic-com Have you tried to remove that dependency and build this module ? It should fail, as there are dependencies on cmsis-core.

Cmsis-core defines target dependencies, you need to fork it anyway.

@markus-becker-tridonic-com
Copy link
Author

Haven't tried to build it yet. So yes, most likely it will fail.

If cmsis-core needs to be forked as well, it really gets hard to add additional targets from the outside of ARM that are part of a family that is already present and mix it with modules from yotta. Any suggestions?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 8, 2015

If cmsis-core needs to be forked as well, it really gets hard to add additional targets from the outside of ARM that are part of a family that is already present and mix it with modules from yotta. Any suggestions?

Can you elaborate? mainly: "the outside of ARM that are part of a family"

@markus-becker-tridonic-com
Copy link
Author

Currently, there is ST429 in yotta. We are working on a different F4, which we would like to upstream, but during development, we need to reference them in module.json without touching each and every module from the bottom of the dependency tree to the top.

@rainierwolfcastle
Copy link

ARM Internal Ref: IOTSFW-1019

@autopulated
Copy link
Contributor

Closing this as there's no way to remove the circular dependency with the current design for CMSIS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants