Check for proxy prefix early, so RemoteAddr doesn't block Accept #2
Conversation
block Accept. And idiomatic cleanups because I couldn't help myself.
| @@ -1,11 +1,12 @@ | |||
| // Package proxoproto implements a net.Listener supporting HAProxy PROTO protocol. | |||
There was a problem hiding this comment.
I have no intention of fixing this. You can take this broken PR and do with it as you please.
Or take this PR and fix the typo later.
There was a problem hiding this comment.
Right, just directing this at @armon when he merges it. Thanks for your help.
|
@armon This pull request does clean up the code but it does not resolve #1. See discussion at https://go-review.googlesource.com/#/c/15832/1 |
|
@armon Any update on this? |
|
+1 |
|
This is fixed in Go 1.6. |
|
It is fixed in Go 1.6 because it does not call the RemoteAddr on client connection. But anyway, in our use case we want to use the library with gorouter from Cloudfoundry which uses go 1.5 :( I am looking at the issue and I would come suggestions. |
|
I linked to an annoying workaround on #1. |
|
(and to reiterate, this PR #2 does not fix the problem and should not be merged.) |
|
@glasser ack, will continue there |
|
I think #4 fixed this. |
|
Given that Go 1.8 and 1.7 are the only supported versions at this point, I'm going to close this. |
Check for proxy prefix early, so RemoteAddr doesn't block Accept.
And idiomatic cleanups because I couldn't help myself.
I don't use this and don't care whether you accept this pull request. Feel free to close it outright if you'd like.
I created it as part of discussion for https://go-review.googlesource.com/#/c/15832/