Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error when selecting shadow map atlas sizes of 512. #2252

Closed
ItsCubeTime opened this issue Jul 5, 2021 · 1 comment · Fixed by #2254
Closed

Build error when selecting shadow map atlas sizes of 512. #2252

ItsCubeTime opened this issue Jul 5, 2021 · 1 comment · Fixed by #2254
Labels
bug This issue describes a bug

Comments

@ItsCubeTime
Copy link

Properties > Render path > shadows > max atlas texture size (and "max atlas texture size spots" & max atlas texture size sun") allows for 512 sizes. "GetMaxAtlasSize" does not have a cooresponding value however:

When you set Cascade size to 256, you are allowed to choose 512 as nax atlas texture size. However in \ArmorySDK\armory\Sources/armory/renderpath/Inc.hx:716: it only goes down to 1024
image
So if you select this 512 option, you will get this error in console:

Scene exported in 0.102s
C:\Users\Oliver\Desktop\Olliver\programs\ArmorySDK\armory\Sources/armory/renderpath/Inc.hx:716: lines 716-786 : Missing return: Int

Haxe compiler error.
Finished in 15.440s
WARNING: 7 warnings occurred during compilation
ERROR: Build failed, check console

Same goes for "Max atlas texture size spots"& "Max atlas texture size sun" if "shadow map atlas single map" is unticked. You can select 512, but theres no code to handle 512 in getMaxAtlasSize

@ItsCubeTime ItsCubeTime added the bug This issue describes a bug label Jul 5, 2021
N8n5h added a commit to N8n5h/armory that referenced this issue Jul 6, 2021
Added 512 option to Inc so it doesn't fails compilation because of
missing option as explained here
armory3d#2252 (comment)
@N8n5h
Copy link
Contributor

N8n5h commented Jul 6, 2021

Thanks for the report 👍 , #2254 should solve it, by simply adding the missing 512 options in the code so it doesn't differ from the ui.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants