Fix shader compilation for some node names with special characters #2916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes shader compilation for nodes or sockets with
§
or$
in their names and also fixes more cases where the shader compiler would output a warning because of consecutive underscores.There are more situations where Armory generates shader code with double underscores, but for some reason I couldn't reproduce a warning in the other cases I found... Nonetheless it may be a good idea to implement a function similar to
utils.safestr()
andutils.safesrc()
but for shader identifiers, this way we could remove some of the (potentially redundant) double underscore correction code from other places and fix this whole class of errors once and for all. This function could also be used to ensure that generated variable names are unique (e.g. by appending consecutive numbers), I believe there are some cases where naming conflicts are possible...