added a new logic node called HideActiveCanvas #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This node hides and unhides the whole active canvas not just certain elements of the canvas. Thus users can easily enable and disable menus for example. I also highly suggest that the LN_set_canvas_visible and LN_get_canvas_visible node are renamed into something like canvas_element_visible. As the node does not actually set the whole canvas visible just parts of it.
Seconded. It's rather confusing. |
MoritzBrueckner
added
Release Notes: Fixes
MoritzBrueckner
added a commit
to MoritzBrueckner/armory
that referenced
this pull request
Oct 14, 2023
- Fixed compilation if Zui is disabled - Fixed deprecation warning for setCanvasVisibility() - Fixed Haxe whitespace (spaces -> tabs) and curly braces code style - armory3d#2946 (comment) - Added proper docstring - Made the node more intuitive by using a "visibility" input instead of a "hide" input that still worked like a "visibility" input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This node hides and unhides the whole active canvas not just certain elements of the canvas. Thus users can easily enable and disable menus for example. I also highly suggest that the LN_set_canvas_visible and LN_get_canvas_visible node are renamed into something like canvas_element_visible. As the node does not actually set the whole canvas visible just parts of it.