Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify PlutoF QC #15

Closed
kmexter opened this issue Jan 3, 2023 · 2 comments
Closed

modify PlutoF QC #15

kmexter opened this issue Jan 3, 2023 · 2 comments
Assignees

Comments

@kmexter
Copy link
Contributor

kmexter commented Jan 3, 2023

No description provided.

@kmexter kmexter changed the title sdf modify PlutoF QC Jan 3, 2023
@kmexter
Copy link
Contributor Author

kmexter commented Jan 3, 2023

The PlutoFQC return a report that shows where a station, country, arms unit does not match what is provided in a master spreadsheet that is provided or is missing in plutoF or from the master overview. It works very well except for one thing: when the plutof value for a station does not match what is in the overview spreadsheet, it returns an "NA" for the cell for that row, while a passed" in the final column to indicate that "yes actually this station name has been changed and the changed value does exist in both the master and plutof". This is confusing - I know what it is doing because it was explained to me, but if someone else where to take over from me, they would not know. So please change it so that the check is done on the station, country, unit names after they have been corrected according to the Master spreadsheet, and then if a station, country, or unit is missing, to then report the name as in PlutoF/the master and that it is missing/not passed. In this way, the QC report tells the person (me or someone else): according to the master correction spreadsheet, these [A,B,C] stations, countries, and arms units are in PlutoF and in the master, these [D,E,F] ones are not in plutof but are in the master, and these ones [G,H] are in the master but not in PlutoF. The format of the output does not need to change, just that there should be no NA entries in any columns.
Not urgent, but should be done before summer 2023.

@kmexter kmexter closed this as completed Jan 16, 2023
@kmexter
Copy link
Contributor Author

kmexter commented Jan 16, 2023

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants